The "at our discretion when market conditions are favorable" language is standard. Almost every farmland syndication PPM I have seen gives the GP full control over disposition. That does not make it acceptable by default; it means you need to look harder at what else the document gives you.
Some deals do have LP protection mechanisms, and they vary a lot. The ones worth looking for: a mandatory sale trigger after a fixed date (year seven or eight is common), a supermajority LP vote right that activates after the stated hold period, a buyout provision where the GP must offer to purchase LP interests at an independent appraisal if no exit has occurred by a certain year, or a right of first offer if the GP sells to an affiliate. None of these are standard, but none are exotic either. They exist in the market. If this PPM has none of them, that is a structural choice, not an oversight.
The assumption doing the most work in your analysis is that the GP's incentive to sell aligns with yours at year seven. It may. But if they are collecting an asset management fee on NAV and the fund has not hit their promote threshold yet, the incentive to hold can be real and legal and completely within their discretion. That is the risk you have not named: fee-driven hold extension, not just market timing judgment.
On the 4.1 percent cash yield, farmland income returns historically sit in the two to five percent range, so this is real but toward the lower end. The return thesis in farmland is usually appreciation plus income, and appreciation is entirely dependent on when and how the GP exits. That compounds the disposition control issue.
The PPM is a securities document. Any interpretation of your rights under it requires a securities attorney, not a forum. Worth the cost on a $50k commitment.
What does the waterfall look like, and does the promote trip before or after LP capital is returned?