What your accountant caught is real, and the gap you're describing catches a lot of LP investors off guard.
Here is what is happening in plain terms. When you own an LP interest in a syndication, the property's depreciation (a paper deduction that reduces taxable income without being a cash expense) flows to you through a document called a K-1. Federal tax law allows a large chunk of that depreciation to be taken in year one under a rule called bonus depreciation. California does not follow that rule. California spreads the deduction out over many years instead. So the same property produces a large loss on your federal return and a much smaller one on your California return, and if you live in California and pay state income tax, the benefit you modeled may be significantly smaller than what arrives.
The strategy guide for syndication LP investing flags depreciation pass-through as one of the structure's real advantages, but it does not go to the state-conformity level, and that is exactly where your math broke down.
A few things I would confirm with a CPA who works with LP investors specifically: how California treats passive losses in future years as the deal matures, whether any of that California loss carries forward, and how your state's rules interact with your other passive income.
I am not a tax advisor, and this is a question where the answer changes based on your full return, so a licensed CPA is the right person to model the corrected numbers.
Your broader point about underwriting state tax treatment separately is a real one. Which state are other folks in this thread filing in? That would help calibrate how widely this gap actually applies in this community.